Enhance get-feature-flag-request.v1.schema#178
Merged
Conversation
Additional changes: - Fix outlets-request-dynamic-context-response.v1.schema.ts schema - Add unit test to make sure that all schemas are valid - Enhance model OutletsRequestContextResponse and OutletsRequestDynamicContextResponse by defining property plugin(s) better - Update typescript version to avoid warnings during execution of unit tests
| }, | ||
| required: ['key', 'defaultValue'], | ||
| anyOf: [ | ||
| { |
Contributor
There was a problem hiding this comment.
maybe using it here { $ref: '#/$defs/payload' }, instead of duplicating the definition?
| console.log(JSON.stringify(validationFunction.errors, null, 2)); | ||
| } | ||
|
|
||
| expect(isValid).toBeTrue(); |
Contributor
There was a problem hiding this comment.
would be nice to use expect(isValid, "Some message").toBeTrue(); to know exactly which test failed and for what schema. Otherwise we only see "Expected false to be true"
Contributor
There was a problem hiding this comment.
also maybe what properties don't respect the schema
- Remove duplicate definition inside schema getFeatureFlagRequest_v1_schema - Add schema name to error if schema validation test fails
zalincaclaudiu
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional changes: